From: Colin Ian King Date: Fri, 9 Dec 2016 14:59:47 +0000 (+0000) Subject: nvmet/fcloop: remove some logically dead code performing redundant ret checks X-Git-Tag: v4.14-rc1~1752^2~4^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7c3a23b85cac5f3caa531f369c1e3a5f1a8b555f;p=platform%2Fkernel%2Flinux-rpi3.git nvmet/fcloop: remove some logically dead code performing redundant ret checks The check to see if ret is non-zero and return this rather than count is redundant in two occassions. It is redundant because prior to this check, the return code ret is already checked for a non-zero error return value and we return from the function at that point. Signed-off-by: Colin Ian King Reviewed-off-by: James Smart Signed-off-by: Christoph Hellwig --- diff --git a/drivers/nvme/target/fcloop.c b/drivers/nvme/target/fcloop.c index bcb8ebe..4e8e6a2 100644 --- a/drivers/nvme/target/fcloop.c +++ b/drivers/nvme/target/fcloop.c @@ -845,7 +845,7 @@ fcloop_create_remote_port(struct device *dev, struct device_attribute *attr, rport->lport = nport->lport; nport->rport = rport; - return ret ? ret : count; + return count; } @@ -952,7 +952,7 @@ fcloop_create_target_port(struct device *dev, struct device_attribute *attr, tport->lport = nport->lport; nport->tport = tport; - return ret ? ret : count; + return count; }