From: stephen hemminger <stephen@networkplumber.org>
Date: Fri, 29 Nov 2013 19:02:43 +0000 (-0800)
Subject: netem: missing break in ge loss generator
X-Git-Tag: v3.13-rc3~28^2~7
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7c2781fa92f5b9ca3188817a56a2ced0400355f3;p=profile%2Fcommon%2Fkernel-common.git

netem: missing break in ge loss generator

There is a missing break statement in the Gilbert Elliot loss model
generator which makes state machine behave incorrectly.

Reported-by: Martin Burri <martin.burri@ch.abb.com
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c
index 75c94e5..6e91323 100644
--- a/net/sched/sch_netem.c
+++ b/net/sched/sch_netem.c
@@ -268,6 +268,7 @@ static bool loss_gilb_ell(struct netem_sched_data *q)
 			clg->state = 2;
 		if (net_random() < clg->a4)
 			return true;
+		break;
 	case 2:
 		if (net_random() < clg->a2)
 			clg->state = 1;