From: Tim-Philipp Müller <tim@centricular.com>
Date: Sun, 25 Sep 2016 15:22:16 +0000 (+0100)
Subject: tests: adder: disable racy flush_start_flush_stop test
X-Git-Tag: 1.19.3~511^2~2662
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7c0ec13942bc59f6da75e432f6d3429b2dd5d9c1;p=platform%2Fupstream%2Fgstreamer.git

tests: adder: disable racy flush_start_flush_stop test

It's been broken for years, and it's unlikely it will ever
be fixed for collectpads/adder now that there's audiomixer
which works fine. So let's disable it, since all it does
is that it creates noise that distracts from other failures.

https://bugzilla.gnome.org/show_bug.cgi?id=708891
---

diff --git a/tests/check/elements/adder.c b/tests/check/elements/adder.c
index 3308a8e..3a9e3b6 100644
--- a/tests/check/elements/adder.c
+++ b/tests/check/elements/adder.c
@@ -1198,6 +1198,7 @@ GST_START_TEST (test_loop)
 
 GST_END_TEST;
 
+#if 0
 GST_START_TEST (test_flush_start_flush_stop)
 {
   GstPadTemplate *sink_template;
@@ -1255,7 +1256,7 @@ GST_START_TEST (test_flush_start_flush_stop)
 }
 
 GST_END_TEST;
-
+#endif
 
 static Suite *
 adder_suite (void)
@@ -1276,7 +1277,12 @@ adder_suite (void)
   tcase_add_test (tc_chain, test_duration_is_max);
   tcase_add_test (tc_chain, test_duration_unknown_overrides);
   tcase_add_test (tc_chain, test_loop);
+  /* This test is racy and occasionally fails in interesting ways
+   * https://bugzilla.gnome.org/show_bug.cgi?id=708891
+   * It's unlikely that it will ever be fixed for adder, works with audiomixer */
+#if 0
   tcase_add_test (tc_chain, test_flush_start_flush_stop);
+#endif
 
   /* Use a longer timeout */
 #ifdef HAVE_VALGRIND