From: Dan Carpenter Date: Wed, 13 Nov 2013 07:40:30 +0000 (+0300) Subject: mfd: ab8500-debugfs: Move dereference after check for NULL X-Git-Tag: v5.15~18622^2~75 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7c0b2380da953d8f63618f530af18eff3518d259;p=platform%2Fkernel%2Flinux-starfive.git mfd: ab8500-debugfs: Move dereference after check for NULL We dereference "desc" before check if it is NULL. I've shifted it around so we check first before dereferencing. Signed-off-by: Dan Carpenter Signed-off-by: Lee Jones --- diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c index e33e385..d1a22aa 100644 --- a/drivers/mfd/ab8500-debugfs.c +++ b/drivers/mfd/ab8500-debugfs.c @@ -1600,7 +1600,6 @@ static int ab8500_interrupts_print(struct seq_file *s, void *p) for (line = 0; line < num_interrupt_lines; line++) { struct irq_desc *desc = irq_to_desc(line + irq_first); - struct irqaction *action = desc->action; seq_printf(s, "%3i: %6i %4i", line, num_interrupts[line], @@ -1608,7 +1607,9 @@ static int ab8500_interrupts_print(struct seq_file *s, void *p) if (desc && desc->name) seq_printf(s, "-%-8s", desc->name); - if (action) { + if (desc && desc->action) { + struct irqaction *action = desc->action; + seq_printf(s, " %s", action->name); while ((action = action->next) != NULL) seq_printf(s, ", %s", action->name);