From: Stefan Roese Date: Wed, 27 Mar 2019 10:20:19 +0000 (+0100) Subject: net: macb: Add small delay after link establishment X-Git-Tag: v2019.07-rc1~36^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7bf9bca7c0a9fe5c63e8fd5c2aa63884d76dace0;p=platform%2Fkernel%2Fu-boot.git net: macb: Add small delay after link establishment I've noticed that the first ethernet packet after PHY link establishment is not tranferred correctly most of the time on my AT91SAM9G25 board. Here I usually see a timeout of a few seconds, which is quite annoying. Adding a small delay (10ms in this case) after the link establishment helps to solve this problem. With this patch applied, this timeout on the first packet is not seen any more. Signed-off-by: Stefan Roese Cc: Wenyou Yang Cc: Eugen Hristev Cc: Joe Hershberger Acked-by: Joe Hershberger --- diff --git a/drivers/net/macb.c b/drivers/net/macb.c index 182331f..7261416 100644 --- a/drivers/net/macb.c +++ b/drivers/net/macb.c @@ -550,8 +550,14 @@ static int macb_phy_init(struct macb_device *macb, const char *name) for (i = 0; i < MACB_AUTONEG_TIMEOUT / 100; i++) { status = macb_mdio_read(macb, MII_BMSR); - if (status & BMSR_LSTATUS) + if (status & BMSR_LSTATUS) { + /* + * Delay a bit after the link is established, + * so that the next xfer does not fail + */ + mdelay(10); break; + } udelay(100); } }