From: Sergei Shtylyov Date: Sat, 15 Feb 2020 20:10:53 +0000 (+0300) Subject: sh_eth: check sh_eth_cpu_data::no_xdfar when dumping registers X-Git-Tag: v5.15~4200^2~417^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7bf47f609f7eaac4f7e9c407a85ad78997288a38;hp=f75ca32403dbf91e20c275719aab705401b9e718;p=platform%2Fkernel%2Flinux-starfive.git sh_eth: check sh_eth_cpu_data::no_xdfar when dumping registers When adding the sh_eth_cpu_data::no_xdfar flag I forgot to add the flag check to __sh_eth_get_regs(), causing the non-existing RDFAR/TDFAR to be considered for dumping on the R-Car gen1/2 SoCs (the register offset check has the final say here)... Fixes: 4c1d45850d5 ("sh_eth: add sh_eth_cpu_data::cexcr flag") Signed-off-by: Sergei Shtylyov Tested-by: Chris Brandt Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index ae9469c..44e8c2a 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -2140,11 +2140,13 @@ static size_t __sh_eth_get_regs(struct net_device *ndev, u32 *buf) add_reg(EESR); add_reg(EESIPR); add_reg(TDLAR); - add_reg(TDFAR); + if (!cd->no_xdfar) + add_reg(TDFAR); add_reg(TDFXR); add_reg(TDFFR); add_reg(RDLAR); - add_reg(RDFAR); + if (!cd->no_xdfar) + add_reg(RDFAR); add_reg(RDFXR); add_reg(RDFFR); add_reg(TRSCER);