From: Dan Carpenter Date: Fri, 7 Jan 2022 07:34:07 +0000 (+0300) Subject: ACPI: pfr_telemetry: Fix info leak in pfrt_log_ioctl() X-Git-Tag: v6.6.17~8373^2^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7bf2e4d5ca1c94a9b0f730498b3d01768a72dcbd;p=platform%2Fkernel%2Flinux-rpi.git ACPI: pfr_telemetry: Fix info leak in pfrt_log_ioctl() The "data_info" struct is copied to the user. It has a 4 byte struct hole after the last struct member so we need to memset that to avoid copying uninitialized stack data to the user. Fixes: b0013e037a8b ("ACPI: Introduce Platform Firmware Runtime Telemetry driver") Signed-off-by: Dan Carpenter Signed-off-by: Rafael J. Wysocki --- diff --git a/drivers/acpi/pfr_telemetry.c b/drivers/acpi/pfr_telemetry.c index da50dd8..9abf350 100644 --- a/drivers/acpi/pfr_telemetry.c +++ b/drivers/acpi/pfr_telemetry.c @@ -83,6 +83,7 @@ static int get_pfrt_log_data_info(struct pfrt_log_data_info *data_info, union acpi_object *out_obj, in_obj, in_buf; int ret = -EBUSY; + memset(data_info, 0, sizeof(*data_info)); memset(&in_obj, 0, sizeof(in_obj)); memset(&in_buf, 0, sizeof(in_buf)); in_obj.type = ACPI_TYPE_PACKAGE;