From: Yang Yingliang Date: Tue, 27 Sep 2022 07:26:12 +0000 (+0800) Subject: usb: musb: core: Switch to use dev_err_probe() helper X-Git-Tag: v6.1-rc5~264^2~25 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7be7231d41971f5e244c0ba8f340dc4697868aa1;p=platform%2Fkernel%2Flinux-starfive.git usb: musb: core: Switch to use dev_err_probe() helper In the probe path, dev_err() can be replaced with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. It also sets the defer probe reason which can be checked later through debugfs. It's more simple in error path. Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/r/20220927072616.913672-2-yangyingliang@huawei.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index bbbcfd4..03027c6 100644 --- a/drivers/usb/musb/musb_core.c +++ b/drivers/usb/musb/musb_core.c @@ -2595,9 +2595,7 @@ fail2: musb_platform_exit(musb); fail1: - if (status != -EPROBE_DEFER) - dev_err(musb->controller, - "%s failed with status %d\n", __func__, status); + dev_err_probe(musb->controller, status, "%s failed\n", __func__); musb_free(musb);