From: Dan Carpenter Date: Tue, 23 May 2017 14:28:36 +0000 (+0300) Subject: block: fix an error code in add_partition() X-Git-Tag: v4.14-rc1~810^2~8 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7bd897cfce1eb373892d35d7f73201b0f9b221c4;p=platform%2Fkernel%2Flinux-rpi3.git block: fix an error code in add_partition() We don't set an error code on this path. It means that we return NULL instead of an error pointer and the caller does a NULL dereference. Fixes: 6d1d8050b4bc ("block, partition: add partition_meta_info to hd_struct") Signed-off-by: Dan Carpenter Signed-off-by: Jens Axboe --- diff --git a/block/partition-generic.c b/block/partition-generic.c index ff07b91..c5ec824 100644 --- a/block/partition-generic.c +++ b/block/partition-generic.c @@ -320,8 +320,10 @@ struct hd_struct *add_partition(struct gendisk *disk, int partno, if (info) { struct partition_meta_info *pinfo = alloc_part_info(disk); - if (!pinfo) + if (!pinfo) { + err = -ENOMEM; goto out_free_stats; + } memcpy(pinfo, info, sizeof(*info)); p->info = pinfo; }