From: Charles Keepax Date: Mon, 6 Mar 2017 16:54:34 +0000 (+0000) Subject: ASoC: wm_adsp: Acknowledge controls should also check the DSP is running X-Git-Tag: v5.15~11288^2~10^2~1^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7b4af793a7a4f8e04175eb6600ba9c8ba855ad20;p=platform%2Fkernel%2Flinux-starfive.git ASoC: wm_adsp: Acknowledge controls should also check the DSP is running We should not be writing acknowledge controls until the firmware is running, as in the case of preloaded firmwares the DSP memory may be unaccessible to whilst in the preloaded state. This means a write to the control during this time could be lost. Signed-off-by: Charles Keepax Signed-off-by: Mark Brown --- diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c index 6313b3d..bbdb72f 100644 --- a/sound/soc/codecs/wm_adsp.c +++ b/sound/soc/codecs/wm_adsp.c @@ -952,7 +952,7 @@ static int wm_coeff_put_acked(struct snd_kcontrol *kctl, mutex_lock(&ctl->dsp->pwr_lock); - if (ctl->enabled) + if (ctl->enabled && ctl->dsp->running) ret = wm_coeff_write_acked_control(ctl, val); else ret = -EPERM;