From: Andy Shevchenko Date: Thu, 12 Jan 2023 11:23:56 +0000 (+0200) Subject: ASoC: amd: acp-es8336: Drop reference count of ACPI device after use X-Git-Tag: v6.1.15~530 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7b1ed88ec3af376363e55514ce935d8f2f6f103f;p=platform%2Fkernel%2Flinux-starfive.git ASoC: amd: acp-es8336: Drop reference count of ACPI device after use [ Upstream commit d784fc8be6814b31854f7b529919ca4506ff8066 ] Theoretically the device might gone if its reference count drops to 0. This might be the case when we try to find the first physical node of the ACPI device. We need to keep reference to it until we get a result of the above mentioned call. Refactor the code to drop the reference count at the correct place. While at it, move to acpi_dev_put() as symmetrical call to the acpi_dev_get_first_match_dev(). Fixes: 02527c3f2300 ("ASoC: amd: add Machine driver for Jadeite platform") Signed-off-by: Andy Shevchenko Acked-by: Vijendar Mukunda Link: https://lore.kernel.org/r/20230112112356.67643-1-andriy.shevchenko@linux.intel.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- diff --git a/sound/soc/amd/acp-es8336.c b/sound/soc/amd/acp-es8336.c index 2fe8df8..8949954 100644 --- a/sound/soc/amd/acp-es8336.c +++ b/sound/soc/amd/acp-es8336.c @@ -198,9 +198,11 @@ static int st_es8336_late_probe(struct snd_soc_card *card) int ret; adev = acpi_dev_get_first_match_dev("ESSX8336", NULL, -1); - if (adev) - put_device(&adev->dev); + if (!adev) + return -ENODEV; + codec_dev = acpi_get_first_physical_node(adev); + acpi_dev_put(adev); if (!codec_dev) dev_err(card->dev, "can not find codec dev\n");