From: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
Date: Fri, 8 Feb 2013 13:58:10 +0000 (+0200)
Subject: gdbus: Always unreference the message in g_dbus_send_message()
X-Git-Tag: 1.13~191
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7b0b28bb41a112bba1d4f33273105ffc54f98c2b;p=platform%2Fupstream%2Fofono.git

gdbus: Always unreference the message in g_dbus_send_message()

A quick fix on g_dbus_send_message(), if check_signal() fails it returns
FALSE without unreferencing the message as it should. This patch fixes
it.
---

diff --git a/gdbus/object.c b/gdbus/object.c
index 43fb1f0..2f8ef45 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c
@@ -1496,7 +1496,7 @@ DBusMessage *g_dbus_create_reply(DBusMessage *message, int type, ...)
 
 gboolean g_dbus_send_message(DBusConnection *connection, DBusMessage *message)
 {
-	dbus_bool_t result;
+	dbus_bool_t result = FALSE;
 
 	if (dbus_message_get_type(message) == DBUS_MESSAGE_TYPE_METHOD_CALL)
 		dbus_message_set_no_reply(message, TRUE);
@@ -1507,11 +1507,12 @@ gboolean g_dbus_send_message(DBusConnection *connection, DBusMessage *message)
 		const GDBusArgInfo *args;
 
 		if (!check_signal(connection, path, interface, name, &args))
-			return FALSE;
+			goto out;
 	}
 
 	result = dbus_connection_send(connection, message, NULL);
 
+out:
 	dbus_message_unref(message);
 
 	return result;