From: commit-bot@chromium.org Date: Tue, 10 Dec 2013 17:08:55 +0000 (+0000) Subject: Revert of https://codereview.chromium.org/109033002/ X-Git-Tag: accepted/tizen/5.0/unified/20181102.025319~9735 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7ad9368687f6132e39ea6b49065e6450e927dcb5;p=platform%2Fupstream%2FlibSkiaSharp.git Revert of https://codereview.chromium.org/109033002/ Reason for revert: I suspect this is causing GM to crash on Mac. R=bungeman@google.com, reed@google.com TBR=bungeman@google.com, reed@google.com NOTREECHECKS=true NOTRY=true Author: mtklein@google.com Review URL: https://codereview.chromium.org/111853003 git-svn-id: http://skia.googlecode.com/svn/trunk@12603 2bbb7eff-a529-9590-31e7-b0007b416f81 --- diff --git a/src/ports/SkFontHost_mac.cpp b/src/ports/SkFontHost_mac.cpp index 7162047..b115965 100755 --- a/src/ports/SkFontHost_mac.cpp +++ b/src/ports/SkFontHost_mac.cpp @@ -2103,13 +2103,7 @@ static SkTypeface* createFromDesc(CFStringRef cfFamilyName, return face; } - AutoCFRelease fontFamilyNameDictionary( - CFDictionaryCreate(kCFAllocatorDefault, - (const void**)&kCTFontFamilyNameAttribute, (const void**)&cfFamilyName, - 1, &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks)); - AutoCFRelease fontDescriptor( - CTFontDescriptorCreateWithAttributes(fontFamilyNameDictionary)); - AutoCFRelease ctNamed(CTFontCreateWithFontDescriptor(fontDescriptor, 0, NULL)); + AutoCFRelease ctNamed(CTFontCreateWithName(cfFamilyName, 1, NULL)); CTFontRef ctFont = CTFontCreateCopyWithAttributes(ctNamed, 1, NULL, desc); if (NULL == ctFont) { return NULL;