From: Larry Ewing Date: Sun, 4 Oct 2020 19:44:53 +0000 (-0500) Subject: make BrowserHttpMessage.Send throw PNSE (#42990) X-Git-Tag: submit/tizen/20210909.063632~5224 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7a80ffd1176bc3544264e650400ed58dbac9cf2d;p=platform%2Fupstream%2Fdotnet%2Fruntime.git make BrowserHttpMessage.Send throw PNSE (#42990) * Throw PNSE on sync version of BrowserHttpHandler.Send * Mark HttpClientHandler.Send as unsupported on browser * Update reference source --- diff --git a/src/libraries/System.Net.Http/ref/System.Net.Http.cs b/src/libraries/System.Net.Http/ref/System.Net.Http.cs index 43b8ddb..c13f88d 100644 --- a/src/libraries/System.Net.Http/ref/System.Net.Http.cs +++ b/src/libraries/System.Net.Http/ref/System.Net.Http.cs @@ -143,6 +143,7 @@ namespace System.Net.Http [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("browser")] public bool UseProxy { get { throw null; } set { } } protected override void Dispose(bool disposing) { } + [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("browser")] protected internal override System.Net.Http.HttpResponseMessage Send(System.Net.Http.HttpRequestMessage request, System.Threading.CancellationToken cancellationToken) { throw null; } protected internal override System.Threading.Tasks.Task SendAsync(System.Net.Http.HttpRequestMessage request, System.Threading.CancellationToken cancellationToken) { throw null; } } diff --git a/src/libraries/System.Net.Http/src/System/Net/Http/BrowserHttpHandler/BrowserHttpHandler.cs b/src/libraries/System.Net.Http/src/System/Net/Http/BrowserHttpHandler/BrowserHttpHandler.cs index 2c77c78..f4aa20a 100644 --- a/src/libraries/System.Net.Http/src/System/Net/Http/BrowserHttpHandler/BrowserHttpHandler.cs +++ b/src/libraries/System.Net.Http/src/System/Net/Http/BrowserHttpHandler/BrowserHttpHandler.cs @@ -137,6 +137,11 @@ namespace System.Net.Http private Dictionary? _properties; public IDictionary Properties => _properties ??= new Dictionary(); + protected internal override HttpResponseMessage Send(HttpRequestMessage request, CancellationToken cancellationToken) + { + throw new PlatformNotSupportedException (); + } + protected internal override async Task SendAsync(HttpRequestMessage request, CancellationToken cancellationToken) { try diff --git a/src/libraries/System.Net.Http/src/System/Net/Http/HttpClientHandler.cs b/src/libraries/System.Net.Http/src/System/Net/Http/HttpClientHandler.cs index 93eb452..81de5ba 100644 --- a/src/libraries/System.Net.Http/src/System/Net/Http/HttpClientHandler.cs +++ b/src/libraries/System.Net.Http/src/System/Net/Http/HttpClientHandler.cs @@ -287,6 +287,7 @@ namespace System.Net.Http public IDictionary Properties => _underlyingHandler.Properties; + [UnsupportedOSPlatform("browser")] protected internal override HttpResponseMessage Send(HttpRequestMessage request, CancellationToken cancellationToken) {