From: Colin Ian King Date: Thu, 4 Feb 2021 15:00:01 +0000 (+0000) Subject: iommu/mediatek: Fix unsigned domid comparison with less than zero X-Git-Tag: accepted/tizen/unified/20230118.172025~7688^2~4^3~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7a5661739d4bf23cd356fb13bb1e0790e09df3c5;p=platform%2Fkernel%2Flinux-rpi.git iommu/mediatek: Fix unsigned domid comparison with less than zero Currently the check for domid < 0 is always false because domid is unsigned. Fix this by casting domid to an int before making the comparison. Signed-off-by: Colin Ian King Acked-by: Will Deacon Link: https://lore.kernel.org/r/20210204150001.102672-1-colin.king@canonical.com Addresses-Coverity: ("Unsigned comparison against 0") Signed-off-by: Joerg Roedel --- diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c index 0ad14a7..1f26262 100644 --- a/drivers/iommu/mtk_iommu.c +++ b/drivers/iommu/mtk_iommu.c @@ -645,7 +645,7 @@ static void mtk_iommu_get_resv_regions(struct device *dev, struct iommu_resv_region *region; int prot = IOMMU_WRITE | IOMMU_READ; - if (domid < 0) + if ((int)domid < 0) return; curdom = data->plat_data->iova_region + domid; for (i = 0; i < data->plat_data->iova_region_nr; i++) {