From: Mike Frysinger Date: Wed, 22 Sep 2010 21:55:17 +0000 (+0000) Subject: opcodes: blackfin: fix decoding of 32bit addresses on 64bit systems X-Git-Tag: sid-snapshot-20101001~91 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7a360e83fc3bfe89586d408f2107242c85a0daf8;p=external%2Fbinutils.git opcodes: blackfin: fix decoding of 32bit addresses on 64bit systems The Blackfin ISA is very exact with regards to address truncation when under/over flowing its 32bit range. On a 32bit system, things work the same and so addresses are decoded properly. On a 64bit system though, the decoded addresses may include the bits that are supposed to have been truncated. So force a 32bit truncation after the address has been calculated. Signed-off-by: Robin Getz Signed-off-by: Mike Frysinger --- diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog index 07c4d89..449954e 100644 --- a/opcodes/ChangeLog +++ b/opcodes/ChangeLog @@ -1,3 +1,7 @@ +2010-09-22 Robin Getz + + * bfin-dis.c (fmtconst): Cast address to 32bits. + 2010-09-22 Mike Frysinger * bfin-dis.c (decode_REGMV_0): Rewrite valid combo checks. diff --git a/opcodes/bfin-dis.c b/opcodes/bfin-dis.c index b17e055..0aec087 100644 --- a/opcodes/bfin-dis.c +++ b/opcodes/bfin-dis.c @@ -138,6 +138,9 @@ fmtconst (const_forms_t cf, TIword x, bfd_vma pc, disassemble_info *outf) if (constant_formats[cf].pcrel) ea += pc; + /* truncate to 32-bits for proper symbol lookup/matching */ + ea = (bu32)ea; + if (outf->symbol_at_address_func (ea, outf) || !constant_formats[cf].exact) { outf->print_address_func (ea, outf);