From: Guillaume Desmottes Date: Thu, 27 Jul 2017 10:12:01 +0000 (+0200) Subject: omx: also reset nFilledLen before calling OMX_FillThisBuffer() X-Git-Tag: 1.19.3~501^2~264 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7a0949b7501ee226e6d59c75136b97cae8591380;p=platform%2Fupstream%2Fgstreamer.git omx: also reset nFilledLen before calling OMX_FillThisBuffer() The spec states that the buffer passed to OMX_FillThisBuffer() needs to be empty. Some implementation may check it actually is by checking its nFilledLen field, so best to reset it as well. https://bugzilla.gnome.org/show_bug.cgi?id=785623 --- diff --git a/omx/gstomx.c b/omx/gstomx.c index cf841e6..191b719 100644 --- a/omx/gstomx.c +++ b/omx/gstomx.c @@ -2078,9 +2078,11 @@ gst_omx_port_populate_unlocked (GstOMXPort * port) /* Reset all flags, some implementations don't * reset them themselves and the flags are not - * valid anymore after the buffer was consumed + * valid anymore after the buffer was consumed. + * Also reset nFilledLen as FillThisBuffer() expects an empty buffer. */ buf->omx_buf->nFlags = 0; + buf->omx_buf->nFilledLen = 0; err = OMX_FillThisBuffer (comp->handle, buf->omx_buf);