From: Alexey Khoroshilov <khoroshilov@ispras.ru>
Date: Fri, 29 Apr 2016 22:11:12 +0000 (+0300)
Subject: ide-tape: fix misprint in failure handling in idetape_init()
X-Git-Tag: v5.15~13162^2~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=79f18a0637033f588accaa05621225c60301514a;p=platform%2Fkernel%2Flinux-starfive.git

ide-tape: fix misprint in failure handling in idetape_init()

If driver_register() failed there is no sense to call driver_unregister().
unregister_chrdev() should be called here.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index 12fa049..9ecf4e3 100644
--- a/drivers/ide/ide-tape.c
+++ b/drivers/ide/ide-tape.c
@@ -2052,12 +2052,12 @@ static int __init idetape_init(void)
 
 	error = driver_register(&idetape_driver.gen_driver);
 	if (error)
-		goto out_free_driver;
+		goto out_free_chrdev;
 
 	return 0;
 
-out_free_driver:
-	driver_unregister(&idetape_driver.gen_driver);
+out_free_chrdev:
+	unregister_chrdev(IDETAPE_MAJOR, "ht");
 out_free_class:
 	class_destroy(idetape_sysfs_class);
 out: