From: Sylwester Nawrocki Date: Thu, 19 Apr 2018 12:04:41 +0000 (+0200) Subject: fimc-is: Suppress warning generated in fimc_is_group_buffer_finish() X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=79ea1abf3aada558a086c40c0bc4aa7bab035272;p=platform%2Fkernel%2Flinux-exynos.git fimc-is: Suppress warning generated in fimc_is_group_buffer_finish() Due to videobuf2 queue cancel call fimc_is_group_buffer_finish() function may be called with invalid group->id. Just return EINVAL instead of WARN_ON() when group->id has GROUP_ID_INVALID value so as to avoid unneeded stack dumps in kernel log while closing video device nodes. Change-Id: I3c5d6fec997ceaf5ae28e2537cfbca9405040bb0 Signed-off-by: Sylwester Nawrocki --- diff --git a/drivers/media/platform/exynos/fimc-is/fimc-is-groupmgr.c b/drivers/media/platform/exynos/fimc-is/fimc-is-groupmgr.c index 67813e896992..271347395fd7 100644 --- a/drivers/media/platform/exynos/fimc-is/fimc-is-groupmgr.c +++ b/drivers/media/platform/exynos/fimc-is/fimc-is-groupmgr.c @@ -1414,8 +1414,10 @@ int fimc_is_group_buffer_finish(struct fimc_is_groupmgr *groupmgr, BUG_ON(!group->leader.vctx); BUG_ON(group->instance >= FIMC_IS_MAX_NODES); - if (WARN_ON(group->id >= GROUP_ID_MAX)) + if (group->id >= GROUP_ID_MAX) { + WARN_ON(group->id != GROUP_ID_INVALID); return -EINVAL; + } if (WARN_ON(index >= FRAMEMGR_MAX_REQUEST)) return -EINVAL;