From: Ryan Lortie <desrt@desrt.ca>
Date: Thu, 21 Jul 2011 07:21:18 +0000 (+0200)
Subject: Advise against using GPrivate
X-Git-Tag: 2.29.14~8
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=79b80579282b2749a9eafe8b95845f434db95969;p=platform%2Fupstream%2Fglib.git

Advise against using GPrivate

GStaticPrivate is really a lot better in almost every way.
---

diff --git a/glib/gthread.c b/glib/gthread.c
index 44075b6..58d76c7 100644
--- a/glib/gthread.c
+++ b/glib/gthread.c
@@ -682,6 +682,10 @@ GThreadFunctions g_thread_functions_for_glib_use = {
 /**
  * GPrivate:
  *
+ * <note><para>
+ * #GStaticPrivate is a better choice for most uses.
+ * </para></note>
+ *
  * The #GPrivate struct is an opaque data structure to represent a
  * thread private data key. Threads can thereby obtain and set a
  * pointer which is private to the current thread. Take our
@@ -741,6 +745,10 @@ GThreadFunctions g_thread_functions_for_glib_use = {
  * non-%NULL, the destructor is called with this pointer as the
  * argument.
  *
+ * <note><para>
+ * #GStaticPrivate is a better choice for most uses.
+ * </para></note>
+ *
  * <note><para>@destructor is used quite differently from @notify in
  * g_static_private_set().</para></note>
  *