From: Hans de Goede Date: Sun, 28 May 2017 12:31:48 +0000 (-0300) Subject: [media] staging: atomisp: Do not call dev_warn with a NULL device X-Git-Tag: v4.14-rc1~332^2~251 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=797f91e6417abcc9a07f9c99dd9128ae7622ee81;p=platform%2Fkernel%2Flinux-rpi.git [media] staging: atomisp: Do not call dev_warn with a NULL device Do not call dev_warn with a NULL device, this silence the following 2 warnings: [ 14.392194] (NULL device *): Failed to find gmin variable gmin_V2P8GPIO [ 14.392257] (NULL device *): Failed to find gmin variable gmin_V1P8GPIO We could switch to using pr_warn for dev == NULL instead, but as comments in the source indicate, the check for these 2 special gmin variables with a NULL device is a workaround for 2 specific evaluation boards, so completely silencing the missing warning for these actually is a good thing. Signed-off-by: Hans de Goede Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c index fe996d0..edaae93 100644 --- a/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c +++ b/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c @@ -704,7 +704,7 @@ int gmin_get_config_var(struct device *dev, const char *var, char *out, if (ret == 0) { memcpy(out, ev->var.Data, ev->var.DataSize); *out_len = ev->var.DataSize; - } else { + } else if (dev) { dev_warn(dev, "Failed to find gmin variable %s\n", var8); }