From: Uwe Kleine-König Date: Sat, 24 Aug 2019 15:37:04 +0000 (+0200) Subject: pwm: rockchip: Don't update the state for the caller of pwm_apply_state() X-Git-Tag: v5.15~5402^2~17 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=797a5ebc26daee5552e668ee4622bc3f47c1f743;p=platform%2Fkernel%2Flinux-starfive.git pwm: rockchip: Don't update the state for the caller of pwm_apply_state() The pwm-rockchip driver is one of only three PWM drivers which updates the state for the caller of pwm_apply_state(). This might have surprising results if the caller reuses the values expecting them to still represent the same state. Signed-off-by: Uwe Kleine-König Signed-off-by: Thierry Reding --- diff --git a/drivers/pwm/pwm-rockchip.c b/drivers/pwm/pwm-rockchip.c index 8eb2db5..83c7627 100644 --- a/drivers/pwm/pwm-rockchip.c +++ b/drivers/pwm/pwm-rockchip.c @@ -212,12 +212,6 @@ static int rockchip_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, goto out; } - /* - * Update the state with the real hardware, which can differ a bit - * because of period/duty_cycle approximation. - */ - rockchip_pwm_get_state(chip, pwm, state); - out: clk_disable(pc->pclk);