From: Dan Carpenter Date: Thu, 24 Feb 2022 15:02:28 +0000 (+0300) Subject: iio: accel: adxl367: unlock on error in adxl367_buffer_predisable() X-Git-Tag: v6.6.17~7878^2~55^2~42 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7948d301c24887a27ff560ca91f8b4cf4cd8e0c8;p=platform%2Fkernel%2Flinux-rpi.git iio: accel: adxl367: unlock on error in adxl367_buffer_predisable() This error path needs to call the mutex_unlock(&st->lock) before returning. Fixes: cbab791c5e2a ("iio: accel: add ADXL367 driver") Signed-off-by: Dan Carpenter Reviewed-by: Cosmin Tanislav Link: https://lore.kernel.org/r/20220224150228.GB6856@kili Signed-off-by: Jonathan Cameron --- diff --git a/drivers/iio/accel/adxl367.c b/drivers/iio/accel/adxl367.c index b452d74..bdc9540 100644 --- a/drivers/iio/accel/adxl367.c +++ b/drivers/iio/accel/adxl367.c @@ -1359,7 +1359,7 @@ static int adxl367_buffer_predisable(struct iio_dev *indio_dev) ret = adxl367_set_measure_en(st, true); if (ret) - return ret; + goto out; ret = adxl367_set_temp_adc_mask_en(st, indio_dev->active_scan_mask, false);