From: Ryan Lortie <desrt@desrt.ca>
Date: Mon, 27 Aug 2012 20:12:30 +0000 (-0400)
Subject: GVariantType: gut g_variant_type_check()
X-Git-Tag: 2.33.12~58
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7936af693477f5b8dfeef4e0d90e6fa4531cf395;p=platform%2Fupstream%2Fglib.git

GVariantType: gut g_variant_type_check()

This function is causing an insane amount of wasted time on some
real-world profiles and it's pretty useless since we already have
GVariantType (as a type different from a string) for the purpose of
static type safety.

Disable it for now.  We can possibly turn this back on again if we solve
bug #544026.

https://bugzilla.gnome.org/show_bug.cgi?id=679835
---

diff --git a/glib/gvarianttype.c b/glib/gvarianttype.c
index aeea1c1..658af77 100644
--- a/glib/gvarianttype.c
+++ b/glib/gvarianttype.c
@@ -486,14 +486,11 @@
 static gboolean
 g_variant_type_check (const GVariantType *type)
 {
-  const gchar *type_string;
-
   if (type == NULL)
     return FALSE;
 
-  type_string = (const gchar *) type;
-#ifndef G_DISABLE_CHECKS
-  return g_variant_type_string_scan (type_string, NULL, NULL);
+#if 0
+  return g_variant_type_string_scan ((const gchar *) type, NULL, NULL);
 #else
   return TRUE;
 #endif