From: Guido Günther <agx@sigxcpu.org>
Date: Mon, 2 Mar 2020 19:13:36 +0000 (+0100)
Subject: drm/etnaviv: Warn when GPU doesn't idle fast enough
X-Git-Tag: v5.10.7~2823^2~14^2~3
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=78f2bfa3181cd7ee134274aa17177dd933c69dc1;p=platform%2Fkernel%2Flinux-rpi.git

drm/etnaviv: Warn when GPU doesn't idle fast enough

If the GPU isn't idle after signalling pm_runtime_mark_last_busy() plus
waiting for the autosuspend delay there's likely something wrong with
the way we check idleness so warn about that.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---

diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
index 26fe340..169db7c 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
@@ -1839,8 +1839,11 @@ static int etnaviv_gpu_rpm_suspend(struct device *dev)
 	mask = gpu->idle_mask & ~(VIVS_HI_IDLE_STATE_FE |
 				  VIVS_HI_IDLE_STATE_MC);
 	idle = gpu_read(gpu, VIVS_HI_IDLE_STATE) & mask;
-	if (idle != mask)
+	if (idle != mask) {
+		dev_warn_ratelimited(dev, "GPU not yet idle, mask: 0x%08x\n",
+				     idle);
 		return -EBUSY;
+	}
 
 	return etnaviv_gpu_hw_suspend(gpu);
 }