From: Viresh Kumar <viresh.kumar@linaro.org>
Date: Wed, 23 Sep 2015 23:48:11 +0000 (-0700)
Subject: greybus: interface: gb_interface_create() isn't called for existing interfaces
X-Git-Tag: v4.14-rc1~2366^2~378^2~21^2~1159
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=78cd67777b71f38dec710dc26f48b685ef6cf120;p=platform%2Fkernel%2Flinux-rpi.git

greybus: interface: gb_interface_create() isn't called for existing interfaces

The callers are ensuring that another interface doesn't exist with the
same interface id and so there is no need to check that from
gb_interface_create() anymore.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
---

diff --git a/drivers/staging/greybus/interface.c b/drivers/staging/greybus/interface.c
index b0253ce..64bf91a 100644
--- a/drivers/staging/greybus/interface.c
+++ b/drivers/staging/greybus/interface.c
@@ -127,13 +127,6 @@ struct gb_interface *gb_interface_create(struct greybus_host_device *hd,
 	struct gb_interface *intf;
 	int retval;
 
-	intf = gb_interface_find(hd, interface_id);
-	if (intf) {
-		dev_err(hd->parent, "Duplicate interface with interface-id: %d will not be created\n",
-			interface_id);
-		return NULL;
-	}
-
 	module = gb_module_find(hd, endo_get_module_id(hd->endo, interface_id));
 	if (!module)
 		return NULL;