From: Alan Jenkins <alan.christopher.jenkins@gmail.com>
Date: Fri, 1 Sep 2017 00:02:32 +0000 (+0100)
Subject: systemctl: remove compiler warning (#6717)
X-Git-Tag: v235~181
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=78ca909980ee6e632ce929fcf238655a425c7db6;p=platform%2Fupstream%2Fsystemd.git

systemctl: remove compiler warning (#6717)

913c1916 changed _ACTION_INVALID to negative, changing the enum to a
signed type.  Take care to avoid comparing it with an unsigned type.

../src/systemctl/systemctl.c: In function ‘start_unit’:
../src/systemctl/systemctl.c:3107:35: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
                 assert(arg_action < ELEMENTSOF(action_table));
---

diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c
index a533132..328b694 100644
--- a/src/systemctl/systemctl.c
+++ b/src/systemctl/systemctl.c
@@ -3104,7 +3104,7 @@ static int start_unit(int argc, char *argv[], void *userdata) {
                         one_name = NULL;
                 }
         } else {
-                assert(arg_action < ELEMENTSOF(action_table));
+                assert(arg_action >= 0 && arg_action < _ACTION_MAX);
                 assert(action_table[arg_action].target);
                 assert(action_table[arg_action].mode);
 
@@ -8177,7 +8177,7 @@ _pure_ static int action_to_runlevel(void) {
                 [ACTION_RESCUE] =    '1'
         };
 
-        assert(arg_action < _ACTION_MAX);
+        assert(arg_action >= 0 && arg_action < _ACTION_MAX);
 
         return table[arg_action];
 }