From: Krzysztof Kozlowski Date: Tue, 1 Sep 2020 14:25:32 +0000 (+0200) Subject: mtd: rawnand: gpmi: Simplify with dev_err_probe() X-Git-Tag: v5.15~2642^2~3^2~10 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=78a73491662aae0cbb3e46f0366d1b45e6027071;p=platform%2Fkernel%2Flinux-starfive.git mtd: rawnand: gpmi: Simplify with dev_err_probe() Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed. Signed-off-by: Krzysztof Kozlowski Signed-off-by: Miquel Raynal Link: https://lore.kernel.org/linux-mtd/20200901142535.12819-3-krzk@kernel.org --- diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c index 86dc83d0de8e..dc8104e67506 100644 --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c @@ -1004,10 +1004,8 @@ static int acquire_dma_channels(struct gpmi_nand_data *this) /* request dma channel */ dma_chan = dma_request_chan(&pdev->dev, "rx-tx"); if (IS_ERR(dma_chan)) { - ret = PTR_ERR(dma_chan); - if (ret != -EPROBE_DEFER) - dev_err(this->dev, "DMA channel request failed: %d\n", - ret); + ret = dev_err_probe(this->dev, PTR_ERR(dma_chan), + "DMA channel request failed\n"); release_dma_channels(this); } else { this->dma_chans[0] = dma_chan;