From: Oleg Nesterov Date: Sun, 16 Sep 2012 17:07:41 +0000 (+0200) Subject: uprobes: Change valid_vma() to demand VM_MAYEXEC rather than VM_EXEC X-Git-Tag: v3.7-rc3~40^2~1^2~12 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=78a320542e6cdb2800cd736b2d136e4261d34f43;p=profile%2Fivi%2Fkernel-adaptation-intel-automotive.git uprobes: Change valid_vma() to demand VM_MAYEXEC rather than VM_EXEC uprobe_register() or uprobe_mmap() requires VM_READ | VM_EXEC, this is not right. An apllication can do mprotect(PROT_EXEC) later and execute this code. Change valid_vma(is_register => true) to check VM_MAYEXEC instead. No need to check VM_MAYREAD, it is always set. Signed-off-by: Oleg Nesterov Acked-by: Srikar Dronamraju --- diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c index 80e8c7b..a9de408 100644 --- a/kernel/events/uprobes.c +++ b/kernel/events/uprobes.c @@ -106,8 +106,8 @@ static bool valid_vma(struct vm_area_struct *vma, bool is_register) if (!is_register) return true; - if ((vma->vm_flags & (VM_HUGETLB|VM_READ|VM_WRITE|VM_EXEC|VM_SHARED)) - == (VM_READ|VM_EXEC)) + if ((vma->vm_flags & (VM_HUGETLB | VM_WRITE | VM_MAYEXEC | VM_SHARED)) + == VM_MAYEXEC) return true; return false;