From: Dan Carpenter Date: Tue, 2 Jan 2018 10:02:19 +0000 (+0000) Subject: afs: Potential uninitialized variable in afs_extract_data() X-Git-Tag: v4.19~1897^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7888da95832d50a87bbfdb9f40620ddc66f94b3c;p=platform%2Fkernel%2Flinux-rpi.git afs: Potential uninitialized variable in afs_extract_data() Smatch warns that: fs/afs/rxrpc.c:922 afs_extract_data() error: uninitialized symbol 'remote_abort'. Smatch is right that "remote_abort" might be uninitialized when we pass it to afs_set_call_complete(). I don't know if that function uses the uninitialized variable. Anyway, the comment for rxrpc_kernel_recv_data(), says that "*_abort should also be initialised to 0." and this patch does that. Signed-off-by: Dan Carpenter Signed-off-by: David Howells --- diff --git a/fs/afs/rxrpc.c b/fs/afs/rxrpc.c index ea1460b..e112665 100644 --- a/fs/afs/rxrpc.c +++ b/fs/afs/rxrpc.c @@ -885,7 +885,7 @@ int afs_extract_data(struct afs_call *call, void *buf, size_t count, { struct afs_net *net = call->net; enum afs_call_state state; - u32 remote_abort; + u32 remote_abort = 0; int ret; _enter("{%s,%zu},,%zu,%d",