From: Karl Williamson Date: Wed, 23 May 2012 23:01:11 +0000 (-0600) Subject: Revert "Fix mktables bug due to the previous overload fix" X-Git-Tag: upstream/5.20.0~6727 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7881e901b6bb688f23c76851cb304a74052929ea;p=platform%2Fupstream%2Fperl.git Revert "Fix mktables bug due to the previous overload fix" mktables had unknowingly been relying on a bug in the overloading code. That bug was fixed by commit f041cf0f9c6469c41de8b73d5f7b426710c3ff8b. Commit 5f9f83be9cdcd54449f7f40db078fe367d780475 is a minimal commit to get mktables to pass its tests as a result of the fixed bug. However, it did not address the underlying problem, which doesn't show up in the typical tests, but does occur when tracing is added or things go wrong and mktables tries to output any of a number of messages, which fail because there is no ".=" operator. A previous commit added the proper overloaded ".=", and so this one is no longer needed, and would be confusing to someone who doesn't know the history. --- diff --git a/lib/unicore/mktables b/lib/unicore/mktables index 7e79841..a6f7225 100644 --- a/lib/unicore/mktables +++ b/lib/unicore/mktables @@ -12933,10 +12933,9 @@ END Type => $ENUM, Initialize => $age, ); - my $q_in = "$in"; $in->add_comment(join_lines(<