From: Markus Elfring Date: Sat, 10 Sep 2016 06:02:06 +0000 (+0200) Subject: ATM-nicstar: Use kmalloc_array() in get_scq() X-Git-Tag: v4.9.8~1241^2~232 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=78706121d59d0692534d087df6eefef5469fc5a1;p=platform%2Fkernel%2Flinux-rpi3.git ATM-nicstar: Use kmalloc_array() in get_scq() * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring Signed-off-by: David S. Miller --- diff --git a/drivers/atm/nicstar.c b/drivers/atm/nicstar.c index 700ed15..50dec13 100644 --- a/drivers/atm/nicstar.c +++ b/drivers/atm/nicstar.c @@ -871,8 +871,9 @@ static scq_info *get_scq(ns_dev *card, int size, u32 scd) kfree(scq); return NULL; } - scq->skb = kmalloc(sizeof(struct sk_buff *) * - (size / NS_SCQE_SIZE), GFP_KERNEL); + scq->skb = kmalloc_array(size / NS_SCQE_SIZE, + sizeof(*scq->skb), + GFP_KERNEL); if (!scq->skb) { dma_free_coherent(&card->pcidev->dev, 2 * size, scq->org, scq->dma);