From: Ben Widawsky Date: Sat, 5 Oct 2013 04:22:49 +0000 (-0700) Subject: drm/i915: Prevent using uninitialized MMIO funcs X-Git-Tag: v3.13-rc1~69^2~3^2~148 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=78511f2a6fc6960c8917d9655fffb687822a0225;p=profile%2Fcommon%2Fkernel-common.git drm/i915: Prevent using uninitialized MMIO funcs For upcoming patches which will have GEN specific MMIO functions, we'll need to initialize the uncore data structure earlier than we do today. If we do not do this, the following will be problematic: intel_uncore_sanitize intel_disable_gt_powersave gen6_disable_rps I915_WRITE(GEN6_RC_CONTROL, 0); <--- MMIO intel_uncore_init // initializes MMIO By initializing the function pointers first, we should be safe. Signed-off-by: Ben Widawsky Reviewed-by: Damien Lespiau Signed-off-by: Daniel Vetter --- diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index b3873c9..ff2083e 100644 --- a/drivers/gpu/drm/i915/i915_dma.c +++ b/drivers/gpu/drm/i915/i915_dma.c @@ -1614,8 +1614,8 @@ int i915_driver_load(struct drm_device *dev, unsigned long flags) intel_irq_init(dev); intel_pm_init(dev); - intel_uncore_sanitize(dev); intel_uncore_init(dev); + intel_uncore_sanitize(dev); /* Try to make sure MCHBAR is enabled before poking at it */ intel_setup_mchbar(dev);