From: Eric Anholt Date: Thu, 28 Mar 2019 18:58:51 +0000 (-0700) Subject: drm/vc4: Fix synchronization firmwarekms against GL rendering. X-Git-Tag: accepted/tizen/unified/20200709.164653~1051 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=78128dc92b44eee4a57d76ccfb0a00d610256120;p=platform%2Fkernel%2Flinux-rpi.git drm/vc4: Fix synchronization firmwarekms against GL rendering. We would present the framebuffer immediately without waiting for rendering to finish first, resulting in stuttering and flickering as a window was dragged around when the GPU was busy enough to not just win the race. Signed-off-by: Eric Anholt --- diff --git a/drivers/gpu/drm/vc4/vc4_firmware_kms.c b/drivers/gpu/drm/vc4/vc4_firmware_kms.c index 85e2736..ee0e6af 100644 --- a/drivers/gpu/drm/vc4/vc4_firmware_kms.c +++ b/drivers/gpu/drm/vc4/vc4_firmware_kms.c @@ -15,6 +15,7 @@ */ #include "drm/drm_atomic_helper.h" +#include "drm/drm_gem_framebuffer_helper.h" #include "drm/drm_plane_helper.h" #include "drm/drm_crtc_helper.h" #include "drm/drm_fourcc.h" @@ -291,7 +292,7 @@ static const struct drm_plane_funcs vc4_plane_funcs = { }; static const struct drm_plane_helper_funcs vc4_primary_plane_helper_funcs = { - .prepare_fb = NULL, + .prepare_fb = drm_gem_fb_prepare_fb, .cleanup_fb = NULL, .atomic_check = vc4_plane_atomic_check, .atomic_update = vc4_primary_plane_atomic_update, @@ -299,7 +300,7 @@ static const struct drm_plane_helper_funcs vc4_primary_plane_helper_funcs = { }; static const struct drm_plane_helper_funcs vc4_cursor_plane_helper_funcs = { - .prepare_fb = NULL, + .prepare_fb = drm_gem_fb_prepare_fb, .cleanup_fb = NULL, .atomic_check = vc4_plane_atomic_check, .atomic_update = vc4_cursor_plane_atomic_update,