From: Nikanth Karthikesan <knikanth@suse.de>
Date: Tue, 16 Feb 2010 18:42:47 +0000 (+0000)
Subject: dm stripe: avoid divide by zero with invalid stripe count
X-Git-Tag: v2.6.33~39^2~6
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=781248c1b50c776a9ef4be1130f84ced1cba42fe;p=platform%2Fupstream%2Fkernel-adaptation-pc.git

dm stripe: avoid divide by zero with invalid stripe count

If a table containing zero as stripe count is passed into stripe_ctr
the code attempts to divide by zero.

This patch changes DM_TABLE_LOAD to return -EINVAL if the stripe count
is zero.

We now get the following error messages:
  device-mapper: table: 253:0: striped: Invalid stripe count
  device-mapper: ioctl: error adding target to table

Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
Cc: stable@kernel.org
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
---

diff --git a/drivers/md/dm-stripe.c b/drivers/md/dm-stripe.c
index e0efc1a..bd58703 100644
--- a/drivers/md/dm-stripe.c
+++ b/drivers/md/dm-stripe.c
@@ -110,7 +110,7 @@ static int stripe_ctr(struct dm_target *ti, unsigned int argc, char **argv)
 	}
 
 	stripes = simple_strtoul(argv[0], &end, 10);
-	if (*end) {
+	if (!stripes || *end) {
 		ti->error = "Invalid stripe count";
 		return -EINVAL;
 	}