From: Daniel Jasper Date: Mon, 5 Jan 2015 10:33:39 +0000 (+0000) Subject: clang-format: [Java] Fix incorrect detection of cast. X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=77ef2be2e492df693c532d7adcf2864ad346c824;p=platform%2Fupstream%2Fllvm.git clang-format: [Java] Fix incorrect detection of cast. After: return (a instanceof List) ? aaaaaaaaaaaaaaaaaaaaaaa( aaaaaaaaaaaaaaaaaaaaa) : aaaaaaaaaaaaaaaaaaaaaaa; After: return (a instanceof List) ? aaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa) : aaaaaaaaaaaaaaaaaaaaaaa; llvm-svn: 225161 --- diff --git a/clang/lib/Format/TokenAnnotator.cpp b/clang/lib/Format/TokenAnnotator.cpp index 2e97fff..331776c 100644 --- a/clang/lib/Format/TokenAnnotator.cpp +++ b/clang/lib/Format/TokenAnnotator.cpp @@ -927,6 +927,8 @@ private: LeftOfParens->MatchingParen->is(TT_LambdaLSquare)) return false; if (Tok.Next) { + if (Tok.Next->is(tok::question)) + return false; if (Style.Language == FormatStyle::LK_JavaScript && Tok.Next->is(Keywords.kw_in)) return false; diff --git a/clang/unittests/Format/FormatTestJava.cpp b/clang/unittests/Format/FormatTestJava.cpp index e27e462..99b25dc 100644 --- a/clang/unittests/Format/FormatTestJava.cpp +++ b/clang/unittests/Format/FormatTestJava.cpp @@ -289,6 +289,10 @@ TEST_F(FormatTestJava, Generics) { verifyFormat("private Foo[] foos;"); verifyFormat("Foo[] foos = this.foos;"); + verifyFormat("return (a instanceof List)\n" + " ? aaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa)\n" + " : aaaaaaaaaaaaaaaaaaaaaaa;", + getStyleWithColumns(60)); verifyFormat( "SomeLoooooooooooooooooooooongType name =\n"