From: Yuichiro Goto <goto@k-tech.co.jp>
Date: Sun, 25 Apr 2021 23:08:03 +0000 (+0900)
Subject: IOMUX: Fix buffer overflow in iomux_replace_device()
X-Git-Tag: v2021.10~202^2~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=77ed7a2ac975e4b72a1bd87e5c475c08c23bb06a;p=platform%2Fkernel%2Fu-boot.git

IOMUX: Fix buffer overflow in iomux_replace_device()

Use of strcat() against an uninitialized buffer would lead
to buffer overflow. This patch fixes it.

Fixes: 694cd5618c ("IOMUX: Introduce iomux_replace_device()")
Signed-off-by: Yuichiro Goto <goto@k-tech.co.jp>
Cc: Peter Robinson <pbrobinson@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Peter Robinson <pbrobinson@gmail.com>
---

diff --git a/common/iomux.c b/common/iomux.c
index b9088aa..c428f71 100644
--- a/common/iomux.c
+++ b/common/iomux.c
@@ -158,8 +158,12 @@ int iomux_replace_device(const int console, const char *old, const char *new)
 			return -ENOMEM;
 		}
 
-		strcat(tmp, ",");
-		strcat(tmp, name);
+		if (arg) {
+			strcat(tmp, ",");
+			strcat(tmp, name);
+		}
+		else
+			strcpy(tmp, name);
 
 		arg = tmp;
 		size = strlen(tmp) + 1;