From: Yaxun (Sam) Liu <yaxun.liu@amd.com>
Date: Mon, 6 Apr 2020 17:52:47 +0000 (-0400)
Subject: [NFC] Minor fix for deferred diagnostics emitter
X-Git-Tag: llvmorg-12-init~9904
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=77e24936022add9e5a0b4ff3db99148c96d113af;p=platform%2Fupstream%2Fllvm.git

[NFC] Minor fix for deferred diagnostics emitter

Differential Revision: https://reviews.llvm.org/D77028
---

diff --git a/clang/lib/Sema/Sema.cpp b/clang/lib/Sema/Sema.cpp
index ff184aa..6c16661 100644
--- a/clang/lib/Sema/Sema.cpp
+++ b/clang/lib/Sema/Sema.cpp
@@ -1555,7 +1555,7 @@ public:
       emitDeferredDiags(FD, Caller);
     // Do not revisit a function if the function body has been completely
     // visited before.
-    if (Done.count(FD))
+    if (!Done.insert(FD).second)
       return;
     InUsePath.insert(FD);
     UsePath.push_back(FD);
@@ -1564,7 +1564,6 @@ public:
     }
     UsePath.pop_back();
     InUsePath.erase(FD);
-    Done.insert(FD);
   }
 
   void checkRecordedDecl(Decl *D) {