From: James Hogan Date: Mon, 16 Dec 2013 10:41:38 +0000 (+0000) Subject: clk: clk-divider: fix divisor > 255 bug X-Git-Tag: v4.9.8~7175^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=778037e1ccb75609846deca9e419449c1dc137fa;p=platform%2Fkernel%2Flinux-rpi3.git clk: clk-divider: fix divisor > 255 bug Commit 6d9252bd9a4bb (clk: Add support for power of two type dividers) merged in v3.6 added the _get_val function to convert a divisor value to a register field value depending on the flags. However it used the type u8 for the div field, causing divisors larger than 255 to be masked and the resultant clock rate to be too high. E.g. in my case an 11bit divider was supposed to divide 24.576 MHz down to 32.768KHz. The divisor was correctly calculated as 750 (0x2ee). This was masked to 238 (0xee) resulting in a frequency of 103.26KHz. Signed-off-by: James Hogan Cc: Rajendra Nayak Cc: linux-arm-kernel@lists.infradead.org Cc: stable@vger.kernel.org Signed-off-by: Mike Turquette --- diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c index 8d3009e..5543b7d 100644 --- a/drivers/clk/clk-divider.c +++ b/drivers/clk/clk-divider.c @@ -87,7 +87,7 @@ static unsigned int _get_table_val(const struct clk_div_table *table, return 0; } -static unsigned int _get_val(struct clk_divider *divider, u8 div) +static unsigned int _get_val(struct clk_divider *divider, unsigned int div) { if (divider->flags & CLK_DIVIDER_ONE_BASED) return div;