From: Tomi Valkeinen Date: Wed, 9 Apr 2014 11:51:01 +0000 (+0300) Subject: drm/omap: remove extra plane->destroy from crtc destroy X-Git-Tag: accepted/tizen/common/20141203.182822~168^2~8^2~7 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=772cdc9777403f10c4229c49645024a502dfd783;p=platform%2Fkernel%2Flinux-arm64.git drm/omap: remove extra plane->destroy from crtc destroy All the planes, including primary planes, are now destroyed by the drm framework. Thus we no longer need the explicit call to plane->destroy from the crtc's destroy function. This patch removes the call, thus fixing the crash caused by double freeing the plane. remove omap_crtc->plane->funcs->destroy(omap_crtc->plane) Signed-off-by: Tomi Valkeinen --- diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c b/drivers/gpu/drm/omapdrm/omap_crtc.c index f59ef93..b3a7529 100644 --- a/drivers/gpu/drm/omapdrm/omap_crtc.c +++ b/drivers/gpu/drm/omapdrm/omap_crtc.c @@ -197,7 +197,6 @@ static void omap_crtc_destroy(struct drm_crtc *crtc) WARN_ON(omap_crtc->apply_irq.registered); omap_irq_unregister(crtc->dev, &omap_crtc->error_irq); - omap_crtc->plane->funcs->destroy(omap_crtc->plane); drm_crtc_cleanup(crtc); kfree(omap_crtc);