From: Joseph Morrow Date: Fri, 29 May 2015 21:25:13 +0000 (-0400) Subject: Refactoring the TB_LOG flag for Android builds. X-Git-Tag: 0.9.2-beta~217 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7711ee452e12dea3949ea812c000f75022e9cf56;p=contrib%2Fiotivity.git Refactoring the TB_LOG flag for Android builds. The TB_LOG flag on Android should not be defined with '-D'. When using compilers for an arch type other than armeabi or x86 (reproducable for sure on armeabi-v7a), the definition for TB_LOG ended up being "-D-DTB_LOG". This issue & solution was raised by an outside contributor Anton Spaans . Change-Id: I9f8caeec37e241fb62772bc8d9f9628f87ff0eb0 Signed-off-by: Joseph Morrow Reviewed-on: https://gerrit.iotivity.org/gerrit/1152 Tested-by: jenkins-iotivity Reviewed-by: Erich Keane --- diff --git a/build_common/android/SConscript b/build_common/android/SConscript index b90beb0..ca96af6 100644 --- a/build_common/android/SConscript +++ b/build_common/android/SConscript @@ -202,7 +202,7 @@ else: env.AppendUnique(CCFLAGS = ['-g']) if env.get('LOGGING'): - env.AppendUnique(CPPDEFINES = ['-DTB_LOG']) + env.AppendUnique(CPPDEFINES = ['TB_LOG']) env.AppendUnique(CPPDEFINES = ['WITH_POSIX', '__ANDROID__']) diff --git a/resource/csdk/connectivity/build/android/SConscript b/resource/csdk/connectivity/build/android/SConscript index 32880e7..1a50785 100644 --- a/resource/csdk/connectivity/build/android/SConscript +++ b/resource/csdk/connectivity/build/android/SConscript @@ -164,7 +164,7 @@ else: env.AppendUnique(CCFLAGS = ['-g']) if env.get('LOGGING'): - env.AppendUnique(CPPDEFINES = ['-DTB_LOG']) + env.AppendUnique(CPPDEFINES = ['TB_LOG']) env.AppendUnique(CPPDEFINES = ['WITH_POSIX', '__ANDROID__']) env.AppendUnique(CCFLAGS = ['-Wall', '-fPIC']) diff --git a/service/notification-manager/SConscript b/service/notification-manager/SConscript index 39c4eb5..7dc9128 100644 --- a/service/notification-manager/SConscript +++ b/service/notification-manager/SConscript @@ -31,7 +31,7 @@ else: env.AppendUnique(CCFLAGS = ['-g']) if env.get('LOGGING'): - env.AppendUnique(CPPDEFINES = ['-DTB_LOG']) + env.AppendUnique(CPPDEFINES = ['TB_LOG']) lib_env = env.Clone() SConscript(env.get('SRC_DIR') + '/service/third_party_libs.scons', 'lib_env')