From: Andrew Morton Date: Tue, 26 Oct 2010 21:22:49 +0000 (-0700) Subject: ratelimit: add comment warning people off printk_ratelimit() X-Git-Tag: upstream/snapshot3+hdmi~12647^2~51 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=77006a0a828249dd69341f960043ee41e7487aa0;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git ratelimit: add comment warning people off printk_ratelimit() printk_ratelimit() was a bad idea - we don't want subsytem A causing ratelimiting of subsystem B's messages. Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/include/linux/kernel.h b/include/linux/kernel.h index e9b492b..77b04ed 100644 --- a/include/linux/kernel.h +++ b/include/linux/kernel.h @@ -277,6 +277,11 @@ asmlinkage int vprintk(const char *fmt, va_list args) asmlinkage int printk(const char * fmt, ...) __attribute__ ((format (printf, 1, 2))) __cold; +/* + * Please don't use printk_ratelimit(), because it shares ratelimiting state + * with all other unrelated printk_ratelimit() callsites. Instead use + * printk_ratelimited() or plain old __ratelimit(). + */ extern int __printk_ratelimit(const char *func); #define printk_ratelimit() __printk_ratelimit(__func__) extern bool printk_timed_ratelimit(unsigned long *caller_jiffies,