From: Lothar Waßmann <LW@KARO-electronics.de>
Date: Tue, 12 Jul 2016 13:30:01 +0000 (+0200)
Subject: drm/imx: parallel-display: check return code from of_get_drm_display_mode()
X-Git-Tag: v5.15~13124^2~17^2~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=76ecd9c9fb24b014a6f33fbb1287ede3be12158b;p=platform%2Fkernel%2Flinux-starfive.git

drm/imx: parallel-display: check return code from of_get_drm_display_mode()

of_get_drm_display_mode() may fail. Check its return code and bail out
on error.

Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---

diff --git a/drivers/gpu/drm/imx/parallel-display.c b/drivers/gpu/drm/imx/parallel-display.c
index 7b7bb31..4abac21 100644
--- a/drivers/gpu/drm/imx/parallel-display.c
+++ b/drivers/gpu/drm/imx/parallel-display.c
@@ -73,10 +73,16 @@ static int imx_pd_connector_get_modes(struct drm_connector *connector)
 
 	if (np) {
 		struct drm_display_mode *mode = drm_mode_create(connector->dev);
+		int ret;
 
 		if (!mode)
 			return -EINVAL;
-		of_get_drm_display_mode(np, &imxpd->mode, OF_USE_NATIVE_MODE);
+
+		ret = of_get_drm_display_mode(np, &imxpd->mode,
+					      OF_USE_NATIVE_MODE);
+		if (ret)
+			return ret;
+
 		drm_mode_copy(mode, &imxpd->mode);
 		mode->type |= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,
 		drm_mode_probed_add(connector, mode);