From: Dan Carpenter Date: Tue, 9 Feb 2016 11:14:12 +0000 (-0200) Subject: [media] usb/cpia2_core: clean up a min_t() cast X-Git-Tag: v5.15~14034^2^2~172 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=76880b4015f7bdbe73bf2c07e42ef0ba7a343d3e;p=platform%2Fkernel%2Flinux-starfive.git [media] usb/cpia2_core: clean up a min_t() cast It makes sense to make the min_t() cast unsigned here since we don't really want negative sizes. Making it signed causes a static checker warning in Smatch. Smatch knows "fw->size - i" is positive but it doesn't know that fw->size is less than INT_MAX so in theory casting it to int might lead to a negative. Signed-off-by: Dan Carpenter Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/usb/cpia2/cpia2_core.c b/drivers/media/usb/cpia2/cpia2_core.c index 187012c..0310fd6 100644 --- a/drivers/media/usb/cpia2/cpia2_core.c +++ b/drivers/media/usb/cpia2/cpia2_core.c @@ -923,7 +923,7 @@ static int apply_vp_patch(struct camera_data *cam) /* ... followed by the data payload */ for (i = 2; i < fw->size; i += 64) { cmd.start = 0x0C; /* Data */ - cmd.reg_count = min_t(int, 64, fw->size - i); + cmd.reg_count = min_t(uint, 64, fw->size - i); memcpy(cmd.buffer.block_data, &fw->data[i], cmd.reg_count); cpia2_send_command(cam, &cmd); }