From: Takashi Iwai <tiwai@suse.de>
Date: Mon, 20 Apr 2020 07:55:29 +0000 (+0200)
Subject: ALSA: usx2y: Fix potential NULL dereference
X-Git-Tag: v5.15~3817^2~36
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7686e3485253635c529cdd5f416fc640abaf076f;p=platform%2Fkernel%2Flinux-starfive.git

ALSA: usx2y: Fix potential NULL dereference

The error handling code in usX2Y_rate_set() may hit a potential NULL
dereference when an error occurs before allocating all us->urb[].
Add a proper NULL check for fixing the corner case.

Reported-by: Lin Yi <teroincn@gmail.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20200420075529.27203-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/usb/usx2y/usbusx2yaudio.c b/sound/usb/usx2y/usbusx2yaudio.c
index 37d290f..ecaf412 100644
--- a/sound/usb/usx2y/usbusx2yaudio.c
+++ b/sound/usb/usx2y/usbusx2yaudio.c
@@ -681,6 +681,8 @@ static int usX2Y_rate_set(struct usX2Ydev *usX2Y, int rate)
 			us->submitted =	2*NOOF_SETRATE_URBS;
 			for (i = 0; i < NOOF_SETRATE_URBS; ++i) {
 				struct urb *urb = us->urb[i];
+				if (!urb)
+					continue;
 				if (urb->status) {
 					if (!err)
 						err = -ENODEV;