From: zhong jiang Date: Sun, 16 Sep 2018 13:20:17 +0000 (+0800) Subject: net: usb: remove redundant null pointer check before of_node_put X-Git-Tag: v5.4-rc1~2266^2~358 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=764ea3714a85bfc0e3e470cee2166b6ef911b9b9;p=platform%2Fkernel%2Flinux-rpi.git net: usb: remove redundant null pointer check before of_node_put of_node_put has taken the null pointer check into account. So it is safe to remove the duplicated check before of_node_put. Signed-off-by: zhong jiang Signed-off-by: David S. Miller --- diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 95a98a2..04f0a09 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -1835,8 +1835,7 @@ static int lan78xx_mdio_init(struct lan78xx_net *dev) node = of_get_child_by_name(dev->udev->dev.of_node, "mdio"); ret = of_mdiobus_register(dev->mdiobus, node); - if (node) - of_node_put(node); + of_node_put(node); if (ret) { netdev_err(dev->net, "can't register MDIO bus\n"); goto exit1;