From: Miklos Szeredi Date: Thu, 14 May 2020 14:44:24 +0000 (+0200) Subject: statx: don't clear STATX_ATIME on SB_RDONLY X-Git-Tag: v5.10.7~2507^2~6 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=761e28fa270a3cc0f2ae9a0f4f778239b91a9df2;p=platform%2Fkernel%2Flinux-rpi.git statx: don't clear STATX_ATIME on SB_RDONLY IS_NOATIME(inode) is defined as __IS_FLG(inode, SB_RDONLY|SB_NOATIME), so generic_fillattr() will clear STATX_ATIME from the result_mask if the super block is marked read only. This was probably not the intention, so fix to only clear STATX_ATIME if the fs doesn't support atime at all. Signed-off-by: Miklos Szeredi Acked-by: David Howells Reviewed-by: Christoph Hellwig --- diff --git a/fs/stat.c b/fs/stat.c index a6709e7..f7f07d1 100644 --- a/fs/stat.c +++ b/fs/stat.c @@ -73,7 +73,8 @@ int vfs_getattr_nosec(const struct path *path, struct kstat *stat, query_flags &= KSTAT_QUERY_FLAGS; /* allow the fs to override these if it really wants to */ - if (IS_NOATIME(inode)) + /* SB_NOATIME means filesystem supplies dummy atime value */ + if (inode->i_sb->s_flags & SB_NOATIME) stat->result_mask &= ~STATX_ATIME; if (IS_AUTOMOUNT(inode)) stat->attributes |= STATX_ATTR_AUTOMOUNT;