From: Ard Biesheuvel Date: Fri, 18 Aug 2017 19:49:35 +0000 (+0100) Subject: efi/libstub/arm64: Use hidden attribute for struct screen_info reference X-Git-Tag: v4.14-rc1~120^2~18 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=760b61d76da6d6a99eb245ab61abf71ca5415cea;p=platform%2Fkernel%2Flinux-exynos.git efi/libstub/arm64: Use hidden attribute for struct screen_info reference To prevent the compiler from emitting absolute references to screen_info when building position independent code, redeclare the symbol with hidden visibility. Tested-by: Matthias Kaehlcke Signed-off-by: Ard Biesheuvel Cc: Linus Torvalds Cc: Matt Fleming Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: linux-efi@vger.kernel.org Link: http://lkml.kernel.org/r/20170818194947.19347-3-ard.biesheuvel@linaro.org Signed-off-by: Ingo Molnar --- diff --git a/arch/arm64/include/asm/efi.h b/arch/arm64/include/asm/efi.h index 8f3043a..464ac85 100644 --- a/arch/arm64/include/asm/efi.h +++ b/arch/arm64/include/asm/efi.h @@ -81,6 +81,9 @@ static inline unsigned long efi_get_max_initrd_addr(unsigned long dram_base, #define alloc_screen_info(x...) &screen_info #define free_screen_info(x...) +/* redeclare as 'hidden' so the compiler will generate relative references */ +extern struct screen_info screen_info __attribute__((__visibility__("hidden"))); + static inline void efifb_setup_from_dmi(struct screen_info *si, const char *opt) { }