From: Jan Harkes Date: Tue, 9 Nov 2021 02:34:39 +0000 (-0800) Subject: coda: avoid flagging NULL inodes X-Git-Tag: v6.1-rc5~2692^2~27 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=76097eb7a48a2ddcf4755773bd501c7aa14cbb7d;p=platform%2Fkernel%2Flinux-starfive.git coda: avoid flagging NULL inodes Somehow we hit a negative dentry in coda_rename even after checking with d_really_is_positive. Maybe something raced and turned the new_dentry negative while we were fixing up directory link counts. Link: https://lkml.kernel.org/r/20210908140308.18491-5-jaharkes@cs.cmu.edu Signed-off-by: Jan Harkes Cc: Alex Shi Cc: Jing Yangyang Cc: Xin Tan Cc: Xiyu Yang Cc: Zeal Robot Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/fs/coda/coda_linux.h b/fs/coda/coda_linux.h index e7b2775..3c2947b 100644 --- a/fs/coda/coda_linux.h +++ b/fs/coda/coda_linux.h @@ -83,6 +83,9 @@ static __inline__ void coda_flag_inode(struct inode *inode, int flag) { struct coda_inode_info *cii = ITOC(inode); + if (!inode) + return; + spin_lock(&cii->c_lock); cii->c_flags |= flag; spin_unlock(&cii->c_lock);