From: Faith Ekstrand <faith.ekstrand@collabora.com>
Date: Tue, 31 Jan 2023 02:12:06 +0000 (-0600)
Subject: nouveau/mme: Fix is_int18 for negative numbers
X-Git-Tag: upstream/23.3.3~3994
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=75deae59887f3bf201139192b36c2d70b75d5862;p=platform%2Fupstream%2Fmesa.git

nouveau/mme: Fix is_int18 for negative numbers

util_mask_sign_extend returns a uint64_t which we need to cast to
uint32_t in order to get the right comparison.  Otherwise, we risk
having ~0 in the top 32 bits and the comparison failing.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>
---

diff --git a/src/nouveau/mme/mme_fermi_builder.c b/src/nouveau/mme/mme_fermi_builder.c
index 2a0a77e..5d58ca5 100644
--- a/src/nouveau/mme/mme_fermi_builder.c
+++ b/src/nouveau/mme/mme_fermi_builder.c
@@ -200,7 +200,7 @@ mme_fermi_reg(uint32_t reg)
 static bool
 is_int18(uint32_t i)
 {
-   return i == util_mask_sign_extend(i, 18);
+   return i == (uint32_t)util_mask_sign_extend(i, 18);
 }
 
 static inline void